[pallet-revive] change some getter APIs to return value in register#6920
Merged
[pallet-revive] change some getter APIs to return value in register#6920
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
xermicus
added
R0-no-crate-publish-required
Member
Author
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7925662 was started for your command Comment |
|
@xermicus Command |
Member
Author
|
/cmd prdoc --audience runtime_dev --bump major |
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
athei
approved these changes
Dec 17, 2024
pgherveou
approved these changes
Dec 17, 2024
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: xermicus <cyrill@parity.io>
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
…aritytech#6920) Call data, return data and code sizes can never exceed `u32::MAX`; they are also not generic. Hence we know that they are guaranteed to always fit into a 64bit register and `revive` can just zero extend them into a 256bit integer value. Which is slightly more efficient than passing them on the stack. --------- Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com> Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: command-bot <> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
7 tasks
This was referenced Jul 16, 2025
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call data, return data and code sizes can never exceed
u32::MAX; they are also not generic. Hence we know that they are guaranteed to always fit into a 64bit register andrevivecan just zero extend them into a 256bit integer value. Which is slightly more efficient than passing them on the stack.